Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] info sur le setup de pre-commit #972

Merged
merged 4 commits into from
Nov 28, 2023
Merged

[Documentation] info sur le setup de pre-commit #972

merged 4 commits into from
Nov 28, 2023

Conversation

raphodn
Copy link
Contributor

@raphodn raphodn commented Nov 9, 2023 •
edited
Loading

Quoi ?

Dans le README il manquait l'info pour setup la config pre-commit

Edit : j'en ai profité pour mettre à jour les versions de black & flake8 (pour qu'elles matchent celles de notre pre-commit)

Autres modifications :

  • selenium a été mis à jour, ce qui modifie la configuration de Firefox

@raphodn raphodn self-assigned this Nov 9, 2023
SebastienReuiller
SebastienReuiller approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@SebastienReuiller SebastienReuiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG ! Ça me fait penser par contre qu'on a une désynchro des versions entre le .pre-commit-config.yaml et le pyproject.toml. Ça pourrait bien nous jouer des tours sur black notamment.

@raphodn
Copy link
Contributor Author

raphodn commented Nov 14, 2023

LG ! Ça me fait penser par contre qu'on a une désynchro des versions entre le .pre-commit-config.yaml et le pyproject.toml. Ça pourrait bien nous jouer des tours sur black notamment.

bien vu, je vais mettre à jour le pyproject 👌

@raphodn raphodn force-pushed the raphodn/doc-pre-commit branch 2 times, most recently from 8ca8738 to 8d6589b Compare November 28, 2023 10:52
@raphodn raphodn changed the base branch from master to raphodn/fix-selenium-tests November 28, 2023 10:52
@raphodn raphodn force-pushed the raphodn/doc-pre-commit branch 2 times, most recently from 188df64 to bc3bd8e Compare November 28, 2023 11:15
@raphodn raphodn changed the base branch from raphodn/fix-selenium-tests to master November 28, 2023 11:24
@raphodn raphodn force-pushed the raphodn/doc-pre-commit branch 3 times, most recently from d3d2c73 to fb8b834 Compare November 28, 2023 12:11
@raphodn raphodn force-pushed the raphodn/doc-pre-commit branch from fb8b834 to 8466a17 Compare November 28, 2023 12:20
@raphodn raphodn merged commit fb506eb into master Nov 28, 2023
4 checks passed
@raphodn raphodn deleted the raphodn/doc-pre-commit branch November 28, 2023 12:26
raphodn added a commit that referenced this pull request Nov 28, 2023
@raphodn
Fix: revert django-storages to 1.13.2. ref #972
595aaeb
@github-actions github-actions bot mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastienReuiller SebastienReuiller SebastienReuiller approved these changes

@madjid-asa madjid-asa Awaiting requested review from madjid-asa

Assignees

@raphodn raphodn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphodn @SebastienReuiller